Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run actions on push to master, pull requests #2166

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 25, 2022

Which issue does this PR close?

Re #2149

Rationale for this change

While wondering "why did we run out of github actions credits" (when my test jobs are waiting for a runner) I looked at the history of actions https://github.com/apache/arrow-rs/actions and saw several jobs were started twice

Screen Shot 2022-07-25 at 10 00 47 AM

I have noticed the same thing on some of my own PRs but I have not found any recent examples.

What changes are included in this PR?

Change jobs to trigger on push to master only as well as PRs

Are there any user-facing changes?

No

@alamb alamb marked this pull request as ready for review July 25, 2022 17:42
@@ -19,6 +19,9 @@
name: "Object Store"

on:
push:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an oversight -- and it means the object store test does not run against master (until this PR gets merged)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

Codecov Report

Merging #2166 (c77e0e1) into master (13e6f39) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2166   +/-   ##
=======================================
  Coverage   82.86%   82.86%           
=======================================
  Files         237      237           
  Lines       61429    61429           
=======================================
  Hits        50902    50902           
  Misses      10527    10527           
Impacted Files Coverage Δ
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.23%) ⬇️
parquet/src/encodings/encoding.rs 93.43% <0.00%> (-0.20%) ⬇️
arrow/src/datatypes/datatype.rs 63.00% <0.00%> (+0.31%) ⬆️
...row/src/array/builder/string_dictionary_builder.rs 91.36% <0.00%> (+0.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@alamb alamb merged commit ec3530d into apache:master Jul 25, 2022
@alamb alamb deleted the alamb/tests_only_on_pr branch July 25, 2022 21:01
@ursabot
Copy link

ursabot commented Jul 25, 2022

Benchmark runs are scheduled for baseline = 13e6f39 and contender = ec3530d. ec3530d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants